-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7 Add Put-route + frontend #15
Conversation
…-put-restaurant # Conflicts: # backend/src/main/java/com/neuefische/team2/backend/restaurant/RestaurantController.java # backend/src/main/java/com/neuefische/team2/backend/restaurant/RestaurantService.java # backend/src/main/java/com/neuefische/team2/backend/restaurant/domain/NewRestaurantDTO.java # backend/src/main/java/com/neuefische/team2/backend/restaurant/domain/Restaurant.java # backend/src/test/java/com/neuefische/team2/backend/restaurant/RestaurantControllerIntegrationTest.java # backend/src/test/java/com/neuefische/team2/backend/restaurant/RestaurantServiceTest.java
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…-put-restaurant # Conflicts: # frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
…-put-restaurant # Conflicts: # frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
…-put-restaurant # Conflicts: # frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
Quality Gate failed for 'neuefische_hh-java-24-2-teamproject-2_frontend'Failed conditions |
Quality Gate passed for 'neuefische_hh-java-24-2-teamproject-2_backend'Issues Measures |
<Button href={`/restaurants/edit/${id}`}>Edit</Button> | ||
<Button href="/">Back</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to navigate via react-router-dom instead of using href
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This href prop is calling react router in the Button component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very good and clear.
I only added a comment because i think we should use the react-router-dom to navigate inside the side
No description provided.