Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7 Add Put-route + frontend #15

Merged
merged 9 commits into from
Jun 6, 2024
Merged

7 Add Put-route + frontend #15

merged 9 commits into from
Jun 6, 2024

Conversation

gcode-de
Copy link
Contributor

@gcode-de gcode-de commented Jun 5, 2024

No description provided.

gcode-de added 4 commits June 4, 2024 12:25
…-put-restaurant

# Conflicts:
#	backend/src/main/java/com/neuefische/team2/backend/restaurant/RestaurantController.java
#	backend/src/main/java/com/neuefische/team2/backend/restaurant/RestaurantService.java
#	backend/src/main/java/com/neuefische/team2/backend/restaurant/domain/NewRestaurantDTO.java
#	backend/src/main/java/com/neuefische/team2/backend/restaurant/domain/Restaurant.java
#	backend/src/test/java/com/neuefische/team2/backend/restaurant/RestaurantControllerIntegrationTest.java
#	backend/src/test/java/com/neuefische/team2/backend/restaurant/RestaurantServiceTest.java
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

gcode-de added 5 commits June 5, 2024 16:43
…-put-restaurant

# Conflicts:
#	frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
…-put-restaurant

# Conflicts:
#	frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
…-put-restaurant

# Conflicts:
#	frontend/src/components/RestaurantForm/RestaurantForm.component.test.tsx
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed for 'neuefische_hh-java-24-2-teamproject-2_frontend'

Failed conditions
23.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed for 'neuefische_hh-java-24-2-teamproject-2_backend'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Comment on lines +36 to 37
<Button href={`/restaurants/edit/${id}`}>Edit</Button>
<Button href="/">Back</Button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably better to navigate via react-router-dom instead of using href

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This href prop is calling react router in the Button component.

Copy link

@DerEns86 DerEns86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very good and clear.
I only added a comment because i think we should use the react-router-dom to navigate inside the side

@gcode-de gcode-de merged commit e4ad9de into main Jun 6, 2024
13 of 14 checks passed
@gcode-de gcode-de deleted the 7-add-put-restaurant branch June 6, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants